Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imageTest folder for future testing purposes. #105

Merged
merged 5 commits into from Mar 29, 2019
Merged

Add imageTest folder for future testing purposes. #105

merged 5 commits into from Mar 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2019

This PR adds a new folder imageTest which comprise of the following files:

  • invalidSampleFolderTest
  • .invalidHiddenImageTest.jpg
  • .invalidHiddenTest.txt
  • invalidIndex.html
  • invalidPDF.pdf
  • invalidRARTest.rar
  • invalidSampleTextTest.txt
  • invalidUnreasonableBigTest.jpg
  • invalidZIPTest.zip
  • validBMPTest.bmp
  • validDuplicateTest.jpg
  • validGIFTest.gif
  • validJPGTest.jpg
  • validMIMETest.png
  • validNOMIMETest.png
  • validPNGTest.png
  • validTIFTest.tif
  • validUnreasonablySmallTest.jpg

All images are marked valid and invalid as per import command action when adding these images to Album i.e. only valid images should be present.

Currently TIFF format is not supported by JavaFX but is included as it is under MIME image format. Opening a TIFF image will not show anything on the UI.

Carrein added 5 commits March 28, 2019 14:32
Former-commit-id: 32f0b2a9706e39205bc7e5810ee97d09f0346166
Former-commit-id: ec816ec3f2fb87d22beef0434f6b74b772209917
Former-commit-id: 0b70e51ffe599c0b02ab3eeee70379d5926ce168
Former-commit-id: 17592466fd7ddecc1dbeee890c7e21d15a501b78
Former-commit-id: 5842abe
@ghost ghost requested a review from itszp March 28, 2019 09:05
@itszp
Copy link

itszp commented Mar 29, 2019

Thanks for providing the test files!

@itszp itszp merged commit 9564a1b into CS2103-AY1819S2-W14-2:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant