You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
isBodyWithinBounds() method in PutShipCommand does not work properly.
Line 123 and 124 should have > inequality instead of >=.
Also, because of the || on line 124, it ignores orientation which should not be the case.
e.g Put a length 2 ship horizontally on e4 on a size 5 map. Will result in invalid because it's not within bounds vertically.
The text was updated successfully, but these errors were encountered:
isBodyWithinBounds() method in PutShipCommand does not work properly.
Line 123 and 124 should have > inequality instead of >=.
Also, because of the || on line 124, it ignores orientation which should not be the case.
e.g Put a length 2 ship horizontally on e4 on a size 5 map. Will result in invalid because it's not within bounds vertically.
The text was updated successfully, but these errors were encountered: