Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo command does not allow for spaces in filepath or filename, but not specified in documentation #171

Closed
nus-se-bot opened this issue Apr 5, 2019 · 1 comment
Assignees

Comments

@nus-se-bot
Copy link

Describe the bug
Using the photo command to add a photo to a Person throws a prompt result "The path of the photo is invalid. ". Upon further checking, the path is valid .However, as the pathname contains spaces " ", either in the filename or the folder names along the path, the photo command does not parse fully the entire path.

To Reproduce
Steps to reproduce the behavior:

  1. Copy a photo to a filepath containing spaces " " in the folder names or image name
  2. Use the photo command to add the photo to a Person
  3. See error

Expected behavior
The specified photo is added to the Person, and displays in the Person card.

Screenshots
image

Additional context
While photos may be renamed, it may be useful to specify in the user guide the restriction on folder names and filenames, as well as specify it in the CommandResult. Otherwise, a workaround is needed.


Reported by: @shaungohsc
Severity: Medium

[original: nus-cs2103-AY1819S2/pe-dry-run#671]

@yinya998 yinya998 self-assigned this Apr 6, 2019
@yinya998
Copy link

yinya998 commented Apr 9, 2019

This is because the argument is trimmed by white space. Fixed alr.

@yinya998 yinya998 closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants