Filter Command is implemented. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barisbatuhan
commented
Mar 4, 2019
barisbatuhan
commented
- Filtering is implemented as a new command
- "filter and/or/clear" processes are included in this command
- User Guide is also updated
- Addressbook is updated. Right now there are 2 addressbooks in the addressbook class. One of them holds the total contact list and the other one holds the filtered version.
- TODO: Redo and Undo commands do not recognize filter command. This will be implemented in this week.
…filter clear. - User Guide is updated with the addition of fiter command explanation. - The necessary methods for filtering to take place are added in the AddressBook.java, Model.java and ModelManager.java classes - A size returning function is created in the UniquePersonList.java class - Instead of having only one person list in the addressbook, a second person list is created and implemented for every single method. It is necessary because when one list holds every contact information and the other list holds the filtered contacts to be showed. - TODO: filtering is not working well with undo and redo operations. This will be implemented. - TODO: a command remove-filtered-contacts will be added to remove all the filtered contacts at once.
- For undo and redo commands, filtering processes are cleared.
25 tasks
barisbatuhan
added
type.Epic
DMGREENHOUSE
added a commit
that referenced
this pull request
Mar 19, 2019
Adding Baris' filter implementations
barisbatuhan
added a commit
that referenced
this pull request
Mar 19, 2019
Merging Updated Skills version
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.