Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs Found in [v1.3] so far #106

Closed
4 tasks done
kthSim opened this issue Mar 29, 2019 · 11 comments
Closed
4 tasks done

Bugs Found in [v1.3] so far #106

kthSim opened this issue Mar 29, 2019 · 11 comments

Comments

@kthSim
Copy link

kthSim commented Mar 29, 2019

  • When history is run after a long list of commands have been entered, the result display box crawls upwards and eats up the input area.
    -- The box is reset if entered is pressed once more, but when history is then run a second time exceptions are thrown (CommandHistory seems to have been wiped

  • New records being added are not saved within the Json

  • Creating new patients on 30th and 31st March causes the program to find invalid dates in addressbook.json
    -- Possible Reason: Record generates a "today"'s date using DateBases' getToday() function which uses Java's Calendar. Java's Calendar class stores months starting from index 0, causing a month of "30-02-2019" to be generated when adding a patient on the 30th of March, and stored into addressbook.json under records. This causes "record.toModelType()" to throw errors when reading from addressbook.json
    -- Can be fixed by adding incrementing the value of int currentMonth within getToday() by 1.

  • Using taskcal to find tasks on different dates causes tasks to disappear from UI with no way to get all tasks to display.

@kthSim
Copy link
Author

kthSim commented Mar 29, 2019

Type any other bugs you find here please, as well as to how to replicate them

@cchj1995
Copy link

cchj1995 commented Mar 29, 2019

Creating new patients on 30th and 31st March causes the program to find invalid dates in addressbook.json

Possible reason:
Record generates a "today"'s date using DateBases' getToday() function which uses Java's Calendar.
Java's Calendar class stores months starting from index 0, causing a month of "30-02-2019" to be generated when adding a patient on the 30th of March, and stored into addressbook.json under records. This causes "record.toModelType()" to throw errors when reading from addressbook.json

Using taskcal to find tasks on different dates causes tasks to disappear from UI with no way to get all tasks to display.

Reason:
taskcal searches for and displays dates with start dates matching the given date and there is currently no way to re-display all tasks.

@kylerwsm
Copy link

I think the teeth layout is not updated when teethedit command is run in the GoTo mode

@cchj1995
Copy link

I think the teeth layout is not updated when teethedit command is run in the GoTo mode

Issue fixed in #108

@kylerwsm
Copy link

kylerwsm commented Mar 30, 2019

New bug: TeethEdit command is now deleting the patient entry from JSON

@kylerwsm
Copy link

New bug: TeethEdit command is now deleting the patient entry from JSON

Should be fixed in #110

@kthSim
Copy link
Author

kthSim commented Mar 31, 2019

New bug: Find cannot find keywords if they are proceeded by punctuation

@kylerwsm
Copy link

New bug: Find cannot find keywords if they are proceeded by punctuation

Hmm, is this really a bug though?

@cchj1995
Copy link

cchj1995 commented Apr 1, 2019

Bug: Adding records with description containing the symbol ":" causes a BadRecordFormatException to be thrown. Record with a description such as "test:test:c:d:e" will cause the exception to be thrown, but the GUI will still show the record as being added. Restarting the application will show that the record has not been saved.

Possible reason:
Storage procedure for record and addressbook.json file involves a 'DIVIDER' which is the symbol : , causing issues in JsonAdaptedRecord which is reading in more split strings than 3.

@kthSim
Copy link
Author

kthSim commented Apr 3, 2019

Bug: Teeth does not show up when program is run from a jar file

@JiaHaoLim
Copy link

JiaHaoLim commented Apr 8, 2019

Copying person A and editing the NRIC of its copy followed by editing the name of its copy results in A being replaced by its copy without changing the name of the copy.
In addition, undo fails to [undo patientedit] in this specific situation can [undo patientedit] in normal situations

Steps to reproduce:
0. Start with empty patient list (Not sure if needed)

  1. add person A
  2. copy A (denote B)
  3. rename B (Fails, person already exists)
  4. change nric of B (Success)
  5. rename B(A is replaced by B, B unchanged)
  6. undo(goes to step 2 instead of 5)

Problem persists even if you close and reopen TeethHub at between step 4 and 5.

@kthSim kthSim closed this as completed Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants