Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3/feature/edit multiple fields #70

Merged
merged 6 commits into from
Nov 6, 2016
Merged

Conversation

ravishwetha
Copy link

Relatively poor application of SLAP, would appreciate any code review if you have the time

Duedate test not passing and name with more than one word can’t be
edited in so regression :(
…rough it

Names with multiple words can be added now
Fixed bug where this was not happening due to how the parser has to
split the newDetail keywords by space. Did not add meaningful test.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.69% when pulling 1e34b40 on C3/feature/edit-multiple-fields into a81cfc9 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.69% when pulling fefff1c on C3/feature/edit-multiple-fields into a81cfc9 on master.

Maintained functionality for use in other functions like prepareSelect
and prepareDelete commands as well
@ravishwetha
Copy link
Author

Will improve SLAP of edit after merge due to present merge conflicts.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.69% when pulling ca5118a on C3/feature/edit-multiple-fields into a81cfc9 on master.

@tessav tessav merged commit f7dca9f into master Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants