Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely untested code. Does the code make sense?
We need separate filters for Tasks and Events unless we return a List which will be messy. So the controller will need to do four steps:
getFilterTokenDefinitions
, and use it to tokenize inputparseIsTaskEvent
, and use it to decide whether to process tasks / events / bothfilterTasks
filterEvents
Reason for so many steps is that if step 3 or 4 go wrong, controller's renderDisambiguation needs a lot of contextual information to do anything sensible. (1) allows the controller to populate the natural dates, and (2) allows the controller to autocomplete "task" or "event".