Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parseIsTaskEvent #166

Merged
merged 5 commits into from
Nov 5, 2016
Merged

Fix parseIsTaskEvent #166

merged 5 commits into from
Nov 5, 2016

Conversation

louietyj
Copy link

@louietyj louietyj commented Nov 5, 2016

Fixes #165

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 50.641% when pulling 08cf10b on fix-parse-istaskevent into 0ea1128 on master.

irvinlim
irvinlim reviewed Nov 5, 2016
View reviewed changes
src/main/java/seedu/todo/controllers/concerns/CalendarItemFilter.java
boolean taskStatusPresent = parsedResult.get("taskStatus") == null;
boolean eventStatusPresent = parsedResult.get("eventStatus") == null;

// Singularize eventType
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this into the else block, then no need to check if null

@louietyj louietyj merged commit 41892cd into master Nov 5, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 50.641% when pulling 64dd751 on fix-parse-istaskevent into 0ea1128 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvinlim irvinlim irvinlim approved these changes

Assignees

@irvinlim irvinlim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louietyj @coveralls @irvinlim