Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite list controller #169

Merged
merged 1 commit into from
Nov 5, 2016
Merged

Rewrite list controller #169

merged 1 commit into from
Nov 5, 2016

Conversation

irvinlim
Copy link

@irvinlim irvinlim commented Nov 5, 2016

Initial rewrite

louietyj
louietyj approved these changes Nov 5, 2016
View reviewed changes
Copy link

@louietyj louietyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll standardize List and ClearControllers... one day.

At least this looks so much better than it was 2 hours ago.

@irvinlim
Copy link
Author

irvinlim commented Nov 5, 2016

Yup, but I think don't really need to standardize, the logic is the same la

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 51.627% when pulling a0370bc on list-controller-rewrite into f00c17c on master.

@louietyj
Copy link

louietyj commented Nov 5, 2016

Looks neater only, that's all lor

@louietyj louietyj merged commit 3611fe7 into master Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louietyj louietyj louietyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irvinlim @coveralls @louietyj