Disambiguator concern #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louietyj
approved these changes
Nov 6, 2016
| * Extracts the key or value of the token value array, and returns it. | ||
| * Accepts a placeholder string in the event that the key or value doesn't exist. | ||
| */ | ||
| private static String extractKeyOrValue(Map<String, String[]> parsedResult, boolean extractValue, String key, String placeholder) { |
There was a problem hiding this comment.
This is actually used everywhere in all the controllers, we can consider moving this to a general Tokenizer static method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted out much of the string replacement logic from ClearController into a Disambiguator concern, since the token replacement should be the same in both ClearController and ListController.
Also, I added a
getUnknownTokenStringmethod which extracts default token, and made the controllers handle them if they exist.Partial #175