Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Config from MainApp #177

Merged
merged 2 commits into from
Nov 6, 2016
Merged

Decouple Config from MainApp #177

merged 2 commits into from
Nov 6, 2016

Conversation

irvinlim
Copy link

@irvinlim irvinlim commented Nov 6, 2016

Necessary so that TestApp can have its own Config also (currently MainApp.config is static, and TestApp extends MainApp).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 61.229% when pulling 81b9356 on decouple-config-mainapp into 7a432d1 on master.

@louietyj louietyj merged commit 5b87fa1 into master Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louietyj louietyj louietyj approved these changes

Assignees

@louietyj louietyj

Labels
type.task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irvinlim @coveralls @louietyj