Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codacy suggestions #112

Merged
merged 16 commits into from Oct 29, 2016
Merged

fix codacy suggestions #112

merged 16 commits into from Oct 29, 2016

Conversation

rachx
Copy link

@rachx rachx commented Oct 25, 2016

fixes #105

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.693% when pulling 8001221 on fix-codacy-suggestions into 2312264 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.693% when pulling a88d2ea on fix-codacy-suggestions into 2a87483 on master.

@burnflare
Copy link

I guess I broke something by being too aggressive, looking at it now

@burnflare
Copy link

@INCENDE Any idea why my changes in this PR has caused LogicManagerTests to fail? Take a look at the travis log then search for "failed"

seedu.agendum.logic.LogicManagerTest > execute_load_successful FAILED
    java.lang.AssertionError: expected:<seedu.agendum.commons.core.UnmodifiableObservableList@72232657> but was:<seedu.agendum.commons.core.UnmodifiableObservableList@1>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:118)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at seedu.agendum.logic.LogicManagerTest.assertCommandBehavior(LogicManagerTest.java:120)
        at seedu.agendum.logic.LogicManagerTest.execute_load_successful(LogicManagerTest.java:933)

@burnflare
Copy link

@INCENDE

Conflicts:

	src/main/java/seedu/agendum/ui/CommandBox.java
@burnflare burnflare merged commit 332d47c into master Oct 29, 2016
@burnflare burnflare deleted the fix-codacy-suggestions branch October 29, 2016 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix suggestions by codacy
4 participants