Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test scripts #221

Merged
merged 9 commits into from Nov 7, 2016
Merged

Fix test scripts #221

merged 9 commits into from Nov 7, 2016

Conversation

rachx
Copy link

@rachx rachx commented Nov 7, 2016

No description provided.

@rachx
Copy link
Author

rachx commented Nov 7, 2016

@burnflare can you fix the links in about us page to the relevant user guide sections here?

@burnflare
Copy link

Working on it

Copy link

@fanwgwg fanwgwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@rachx
Copy link
Author

rachx commented Nov 7, 2016

@burnflare
square brackets for collate are intentional
it should look like this
https://github.com/nus-cs2103/website/blob/master/contents/AboutUs.md

remember to add our userid too

@burnflare
Copy link

@rachx Thanks, updating to that format

@burnflare
Copy link

Brought the brackets back

@rachx
Copy link
Author

rachx commented Nov 7, 2016

See last PR. I thought it is bad that we are giving ids when the ids will change after any updates. But we can't give specific names

@burnflare
Copy link

Yup that's a good change

@burnflare burnflare merged commit 274e017 into master Nov 7, 2016
@burnflare burnflare deleted the correct-test-script branch November 7, 2016 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants