Collated for review #224
Merged
Collated for review #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@okkhoy Would be great if you could review the code quality for Made a clean(almost) PR for that. Thanks a lot :) |
okkhoy
reviewed
Nov 10, 2017
collated/main/tshradheya.md
Outdated
| import seedu.address.commons.events.BaseEvent; | ||
|
|
||
| /** | ||
| * Event to trigger reading and storing of image |
There was a problem hiding this comment.
better comment would be Triggers event ...
collated/main/tshradheya.md
Outdated
| return isRead; | ||
| } | ||
|
|
||
| public void setRead(boolean b) { |
collated/main/tshradheya.md
Outdated
| import seedu.address.model.person.ReadOnlyPerson; | ||
|
|
||
| /** | ||
| * Event raised on 'select' command's successful execution |
There was a problem hiding this comment.
may fix all header comments to follow the convention we specify
collated/main/tshradheya.md
Outdated
| import seedu.address.model.person.exceptions.PersonNotFoundException; | ||
|
|
||
| /** | ||
| * Selects a person identified using it's last displayed index from the address book. |
| || (other instanceof ViewTagCommand // instanceof handles nulls | ||
| && this.predicate.equals(((ViewTagCommand) other).predicate)); // state check | ||
| } | ||
|
|
There was a problem hiding this comment.
errr... why so many blank lines at the end of file?
collated/main/tshradheya.md
Outdated
| try { | ||
| index = ParserUtil.parseIndex(splitArgs[0]); | ||
| } catch (IllegalValueException ive) { | ||
| throw new ParseException(String.format(MESSAGE_INVALID_COMMAND_FORMAT, DisplayPictureCommand.MESSAGE_USAGE)); |
|
Code quality improved. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.