Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up the UI, compresses SkillLevel and Skill into one line #81

Merged
merged 8 commits into from
Oct 31, 2018

Conversation

derpyplops
Copy link

No description provided.

@derpyplops derpyplops added type.enhancement An enhancement to an existing story priority.low Unlikely to do labels Oct 30, 2018
@derpyplops derpyplops added this to the v1.3 milestone Oct 30, 2018
@derpyplops derpyplops self-assigned this Oct 30, 2018
@coveralls
Copy link

coveralls commented Oct 30, 2018

Pull Request Test Coverage Report for Build 207

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 68.244%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/ui/PersonCard.java 0 1 0.0%
Totals Coverage Status
Change from base Build 192: 0.08%
Covered Lines: 1788
Relevant Lines: 2620

💛 - Coveralls

@@ -5,7 +5,7 @@
*/
public class LoginManager {

private static boolean isLoginSuccessful = false;
private static boolean isLoginSuccessful = true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to change this back to false next time.

@Boon-Jun Boon-Jun merged commit f759973 into CS2113-AY1819S1-F09-1:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.low Unlikely to do type.enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants