implementation of more member functions #99
Conversation
kangmingtay
added
status.ongoing
There was a problem hiding this comment.
The three test methods: updateMemberPoints(), invalidMemberInOrder() and validMemberInOrder(), should assert some sort of expected output, otherwise the test would be redundant.
For updateMemberPoints() and validMemberInOrder() assert an expected output for them.
For invalidMemberInOrder(), if you don't want to use assertion can use something like:
@test(expected = IndexOutOfBoundsException.class)
instead of throwing an Exception
…e result becomes negative
kangmingtay
added
status.review-pending
src/seedu/addressbook/data/Rms.java
Outdated
| * Checks if a member in the order is in the list of members | ||
| * Returns the member if found, else create a new Member using the data from the member in the order | ||
| */ | ||
| public Member findMemberInOrder(Member orderMember) { |
There was a problem hiding this comment.
Can you change the parameter type to ReadOnlyMember ?
There was a problem hiding this comment.
Better yet, you can create another overloading version that can except ReadOnlyMember instead
There was a problem hiding this comment.
Changing the parameter type to ReadOnlyMember can cover both Member and ReadOnlyMember inputs
src/seedu/addressbook/data/Rms.java
Outdated
| Date date = orderMember.getDate(); | ||
|
|
||
| for(Member member : allMembers) { | ||
| if((name == member.getName()) && (points == member.getPoints()) && (date == member.getDate())) { |
There was a problem hiding this comment.
you can make use of the isSameStateAs() method from ReadOnlyMember.java
px1099
added
status.completed
add command to remove member from the member list