Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some test case issues, added tests for addtag() and removeTag() #138

Merged
merged 24 commits into from Oct 14, 2018
Merged

Fixed some test case issues, added tests for addtag() and removeTag() #138

merged 24 commits into from Oct 14, 2018

Conversation

aaryam253
Copy link

No description provided.

aaryam253 and others added 23 commits September 30, 2018 19:12
@aaryam253
Enabled GUI Tests
6dc7110
@aaryam253
Tried to make GUI tests work
a96b635
@aaryam253
Merge branch 'master' of https://github.com/CS2113-AY1819S1-F09-3/main
4f8ebb5
@aaryam253
Changed starting screen logo
b9cb828
@aaryam253
Added customised tags for Invités, changed app name
3ec4cce
@aaryam253
Merge branch 'master' of https://github.com/CS2113-AY1819S1-F09-3/main
579020d
@aaryam253
Merge branch 'master' of https://github.com/CS2113-AY1819S1-F09-3/main
6244500
@aaryam253
Added Gmail API dependencies
8f9e73a
@aaryam253
Merge branch 'master' of https://github.com/CS2113-AY1819S1-F09-3/main
ac9b01c
@aaryam253
Removed GUI tests from build.gradle
59ade3f
@aaryam253
Added files for RemoveTag() command
531cab1
@aaryam253
Merge branch 'master' of https://github.com/CS2113-AY1819S1-F09-3/main
13e8713
@aaryam253
Adding a RemoveTag() command that removes specified tag from all gues…
5d225f4 
…ts - IN PROGRESS
@aaryam253
Merge branch 'master' of https://github.com/CS2113-AY1819S1-F09-3/main
d364a93 
# Conflicts:
#	src/test/java/seedu/address/model/AddressBookTest.java
@aaryam253
Removed GUI tests
9528edf
@aaryam253
Merge branch 'master' of https://github.com/aaryamNUS/main
ffeee00 
# Conflicts:
#	src/main/java/seedu/address/logic/commands/RemoveTagCommand.java
#	src/main/java/seedu/address/logic/parser/RemoveTagCommandParser.java
#	src/main/java/seedu/address/ui/PersonCard.java
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
#	src/test/java/seedu/address/logic/parser/RemoveTagCommandParserTest.java
#	src/test/java/seedu/address/model/AddressBookTest.java
@aaryam253
Merge branch 'master' of https://github.com/CS2113-AY1819S1-F09-3/main
a75e4f1
Added JUnit and integration tests for removeTag()
ca6f9c8
Added Junit and integration tests for AddTag() command
0625485
Checkstyle formatting
7c93e0b
Checkstyle formatting
595cddd
More checkstyle issues
90c8b70
More checkstyle changes
ec4f32a
@aaryam253 aaryam253 added type.task Something that needs to be done, but not a story, bug, or an epic. priority.medium Nice to have labels Oct 14, 2018
@aaryam253 aaryam253 added this to the v1.2 milestone Oct 14, 2018
@aaryam253 aaryam253 self-assigned this Oct 14, 2018
@aaryam253 aaryam253 added this to In progress in Invités via automation Oct 14, 2018
@coveralls
Copy link

coveralls commented Oct 14, 2018 •
edited

Pull Request Test Coverage Report for Build 202

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.1%) to 61.663%
Totals Coverage Status
Change from base Build 200: 3.1%
Covered Lines: 1261
Relevant Lines: 2045
💛 - Coveralls

@aaryam253 aaryam253 requested review from kronicler and removed request for kronicler October 14, 2018 15:31
kronicler
kronicler approved these changes Oct 14, 2018
View reviewed changes
Copy link

@kronicler kronicler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Test cases follow the correct format too!

Invités automation moved this from In progress to Completed Oct 14, 2018
@kronicler kronicler merged commit b4cabb7 into CS2113-AY1819S1-F09-3:master Oct 14, 2018
aaryam253 added a commit to aaryam253/Invites-OOP-Java-Project that referenced this pull request Oct 15, 2018
@aaryam253
Merge pull request CS2113-AY1819S1-F09-3#138 from aaryamNUS/master
6894d5a 
Fixed some test case issues, added tests for addtag() and removeTag() and edited user guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kronicler kronicler kronicler approved these changes

Assignees

@aaryam253 aaryam253

Labels
priority.medium Nice to have type.task Something that needs to be done, but not a story, bug, or an epic.
Projects
No open projects
Invités
  
Completed
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aaryam253 @coveralls @kronicler