Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When adding new person, {private Fees: 0.00 / 00-00-0000} shows in box #190

Closed
nus-pe-script opened this issue Nov 2, 2018 · 0 comments
Closed

When adding new person, {private Fees: 0.00 / 00-00-0000} shows in box #190

nus-pe-script opened this issue Nov 2, 2018 · 0 comments
Assignees
@lucdx
Labels
RequestClosure Indicates issue may be solved, request closure from deadline IC response.Accepted

Comments

@nus-pe-script
Copy link

Describe the bug
After adding a person there is information in the text box of stuff that is not declared in the user guide (private fees)

To Reproduce
Steps to reproduce the behavior:

  1. Run the jar file
  2. Add new person according to instructions
  3. See the box with info text
  4. See line {private Fees: 0.00 / 00-00-0000}

Expected behavior
I expected to only see the information i entered when adding the new person.

Screenshots
image

Reported by: @T0roloco
Severity: Not Specified

[original: nusCS2113-AY1819S1/pe-1#320]
@lucdx lucdx self-assigned this Nov 3, 2018
@micklwl micklwl mentioned this issue Nov 3, 2018
Closed
lucdx added a commit to lucdx/main that referenced this issue Nov 8, 2018
@lucdx
Fixed bugs wrt to issue CS2113-AY1819S1-F10-1#190 and CS2113-AY1819S1…
10c732e 
…-F10-1#195
0WN463 pushed a commit that referenced this issue Nov 10, 2018
@lucdx @0WN463
V1.4 Fees (#221)
4ee31e7 
* Fixed crash bug, issue #202

* Fixed bug for invalid date, issue #198

* Failed optional fees thing

* Revert "Failed optional fees thing"

This reverts commit b0ad822.

* notes to self about how to update to v1.4

* Made formatter tests more readable, as reviewed in PR#159 by Tek In

* Made methods sound more like verbs, as reviewed by Tek In in PR#159

* Small typo

* Fixed bugs wrt to issue #190 and #195

* Fixed tests w new format

* More test fixes

* New PaidFeesCommand to initialise fees back to 0 values to overcome REGEX

* Test fixes

* tag removal in PaidFees

* Fixed checkstyle for new paidfees command

* Test for PaidFeesCommand

* Checkstyle

* Codacy

* Checkstyle

* Added more tests for editfees and paidfees

* Renames test cases to snake_case

* Edits for name

* Checkstyle

* More Tests

* More Tests

* Move comparator from UniquePersonList to Utils

* Import Order

* Tests

* fix

* Edited ViewAll LogicTest to show 1 fee

* Renamed Tests to correct format

* Fix changes requested.

* Created new DateString converters in Utils to address issue brought up

* Checkstyle
@lucdx lucdx added the RequestClosure Indicates issue may be solved, request closure from deadline IC label Nov 10, 2018
@Meg1456 Meg1456 closed this as completed Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucdx lucdx

Labels
RequestClosure Indicates issue may be solved, request closure from deadline IC response.Accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Meg1456 @lucdx @nus-pe-script