V1.3 Enhancement #157
Merged
V1.3 Enhancement #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into Enhancement
…into Enhancement
This was referenced Nov 1, 2018
Meg1456
reviewed
Nov 1, 2018
| * Extracts the the target person in the last shown list from the given arguments. | ||
| * @throws IndexOutOfBoundsException if the target index is out of bounds of the last viewed listing | ||
| */ | ||
| protected Assessment getTargetAssessment() throws IndexOutOfBoundsException { |
There was a problem hiding this comment.
Can use assessment index out of bounds exception here instead. I have created it separately.
There was a problem hiding this comment.
Lawl, I just extracted from yours, cause yours also didn't use it in the master
| * *User* defines what access level the *Privilege* object have, which is implemented by *BasicUser*, *TutorUser* and *AdminUser*. + | ||
| * *BasicUser* is the class with the lowest access level, and the ancestor to other 2 *User* classes. + | ||
| * To create an increasing level of access, each *User* of a higher level inherits from the successively lower one. + | ||
| * *User* levels have their own list of new commands they can run, which is appended to the list inherited from their parent. + |
There was a problem hiding this comment.
Do you think that list is necessary here? Or maybe even in the appendix. Just so that it is clear what each of these privilege levels correspond to.
There was a problem hiding this comment.
CS2101 no like how it was formatted previously (separate lines). I am obliged to satisfy her needs
…into Enhancement
…into Enhancement
…into Enhancement
…into Enhancement
…into Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.