Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.4 Exam #205

Merged
merged 17 commits into from Nov 5, 2018
Merged

V1.4 Exam #205

merged 17 commits into from Nov 5, 2018

Conversation

micklwl
Copy link

@micklwl micklwl commented Nov 3, 2018

Update methods and documentation.
Update format of printing exam.
Updated AttendanceTest so it does not erase the developer's storage files.
Resolves #177, Resolves #197, Resolves #200

@coveralls
Copy link

coveralls commented Nov 3, 2018

Pull Request Test Coverage Report for Build 683

  • 57 of 59 (96.61%) changed or added relevant lines in 16 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 82.422%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/seedu/addressbook/storage/StorageFile.java 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
src/seedu/addressbook/storage/StorageFile.java 1 68.38%
src/seedu/addressbook/storage/jaxb/AdaptedStatisticsBook.java 3 58.33%
src/seedu/addressbook/data/StatisticsBook.java 3 44.44%
src/seedu/addressbook/data/person/UniqueStatisticsList.java 4 44.12%
Totals Coverage Status
Change from base Build 676: 0.02%
Covered Lines: 2185
Relevant Lines: 2651

💛 - Coveralls

@micklwl micklwl added the Ready To Merge Indicates that this PR is complete and ready to be merged label Nov 3, 2018
takerWord = "Taker";
} else {
takerWord = "Takers";
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small nitpick, takerWord can be final

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

@micklwl micklwl removed the Ready To Merge Indicates that this PR is complete and ready to be merged label Nov 5, 2018
@micklwl micklwl added the Ready To Merge Indicates that this PR is complete and ready to be merged label Nov 5, 2018
@0WN463 0WN463 merged commit ed2a2f0 into CS2113-AY1819S1-F10-1:master Nov 5, 2018
@micklwl micklwl deleted the v1.4 branch November 5, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge Indicates that this PR is complete and ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants