v1.41 Attendance bug fixes and UGDG Language corrected #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port statements to prevent unwanted dependencies.
… declared and/or assigned, but not used.
# Conflicts: # src/seedu/addressbook/data/person/Attendance.java # src/seedu/addressbook/data/person/Person.java # src/seedu/addressbook/parser/Parser.java # test/java/seedu/addressbook/logic/LogicTest.java
Import statements allow the use of non-fully qualified names. The use of a fully qualified name which is covered by an import statement is redundant. Consider using the non-fully qualified name.
Position literals first in comparisons, if the second argument is null then NullPointerExceptions can be avoided, they will just return false.
Reassigning values to incoming parameters is not recommended. Use temporary local variables instead.
Pull Request Test Coverage Report for Build 879
💛 - Coveralls |
|
Resolves xxx. in your comment to link the issue to your pr. |
0WN463
reviewed
Nov 11, 2018
| @@ -19,7 +19,7 @@ | |||
| public static final String COMMAND_WORD = "attendance"; | |||
| public static final String MESSAGE_USAGE = COMMAND_WORD + ":\n" | |||
| + "Updates the attendance of a student. \n" | |||
| + "Parameters: indexOfPerson d/dd-mm-yyyy att/attendance \n" | |||
| + "Parameters: INDEX d/dd-MM-yyyy att/ISPRESENT \n" | |||
| + "\tExample: " + COMMAND_WORD + " " + "1 d/29-09-2018 att/1 \n" | |||
There was a problem hiding this comment.
Intriguing, why is only the month capitalized lawl?
There was a problem hiding this comment.
I think it should be DATE instead of the format
There was a problem hiding this comment.
Mick, u literally told me to change it from date to the format.
Tek In, mm means minutes. MM is month
There was a problem hiding this comment.
Its just odd that the rest uppercase everything, while yours is only the month
There was a problem hiding this comment.
Sorry about that, I was comparing with your other commands. However, now that I look through everyone's commands, for PARAMETERS, they are words and not format related
|
Also, merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the following Issues:
[Attendance] viewAttendace wrong argument
Resolves #268
[Attendance] Command parameters
Resolves #267
[Attendance] viewAttendanceDate command
Resolves #266
[Attendance] Repeated lines for invalid date in replaceAtten command
Resolves #256
UGDG has corrected grammer and spelling