Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screening history feature and add codecov #108

Conversation

muhdharun
Copy link

just a test commit

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@7bab73b). Click here to learn what that means.
The diff coverage is 51.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage          ?   33.25%           
  Complexity        ?      185           
=========================================
  Files             ?       58           
  Lines             ?     1350           
  Branches          ?      149           
=========================================
  Hits              ?      449           
  Misses            ?      879           
  Partials          ?       22
Impacted Files Coverage Δ Complexity Δ
src/seedu/addressbook/common/Messages.java 0% <ø> (ø) 0 <0> (?)
.../seedu/addressbook/data/person/ReadOnlyPerson.java 79.16% <ø> (ø) 5 <0> (?)
src/seedu/addressbook/data/person/NRIC.java 83.33% <ø> (ø) 6 <0> (?)
...u/addressbook/storage/jaxb/AdaptedAddressBook.java 100% <ø> (ø) 5 <0> (?)
src/seedu/addressbook/ui/Formatter.java 0% <0%> (ø) 0 <0> (?)
src/seedu/addressbook/ui/MainWindow.java 0% <0%> (ø) 0 <0> (?)
src/seedu/addressbook/commands/CheckCommand.java 0% <0%> (ø) 0 <0> (?)
.../seedu/addressbook/storage/jaxb/AdaptedPerson.java 91.89% <100%> (ø) 7 <0> (?)
...eedu/addressbook/data/person/UniquePersonList.java 62.79% <100%> (ø) 13 <1> (?)
src/seedu/addressbook/data/person/Person.java 71.42% <100%> (ø) 16 <3> (?)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bab73b...224c9dc. Read the comment docs.

@iamputradanish iamputradanish changed the title test commit Add screening history feature and add codecov Oct 16, 2018
@iamputradanish iamputradanish added priority.high Must do type.epic A big feature which can be broken down into smaller stories e.g. search type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new labels Oct 16, 2018
@iamputradanish iamputradanish added this to the v1.3 milestone Oct 16, 2018
Copy link

@iamputradanish iamputradanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature. Do add more arguements to be output in future versions.

@iamputradanish iamputradanish merged commit 78be6b0 into CS2113-AY1819S1-F10-3:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.high Must do type.epic A big feature which can be broken down into smaller stories e.g. search type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants