Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize format for DG #120

Merged
merged 6 commits into from Oct 18, 2018
Merged

Standardize format for DG #120

merged 6 commits into from Oct 18, 2018

Conversation

ongweekeong
Copy link

No description provided.

@ongweekeong ongweekeong added the type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Oct 17, 2018
@ongweekeong ongweekeong added this to the v1.3 milestone Oct 17, 2018
@ongweekeong ongweekeong self-assigned this Oct 17, 2018
@codecov-io
Copy link

codecov-io commented Oct 18, 2018 •
edited

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #120   +/-   ##
=========================================
  Coverage     34.07%   34.07%           
  Complexity      191      191           
=========================================
  Files            58       58           
  Lines          1429     1429           
  Branches        153      153           
=========================================
  Hits            487      487           
  Misses          916      916           
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
src/seedu/addressbook/inbox/Msg.java 9.33% <ø> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/parser/Parser.java 80.34% <ø> (ø) 28 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ccc62e...fe63182. Read the comment docs.

iamputradanish
iamputradanish approved these changes Oct 18, 2018
View reviewed changes
Copy link

@iamputradanish iamputradanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on the documentation

@iamputradanish iamputradanish merged commit 657f333 into CS2113-AY1819S1-F10-3:master Oct 18, 2018
@iamputradanish iamputradanish changed the title Standardized formatting for DG Standardize format for DG Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamputradanish iamputradanish iamputradanish approved these changes

@andyrobert3 andyrobert3 Awaiting requested review from andyrobert3

@muhdharun muhdharun Awaiting requested review from muhdharun

Assignees

@ongweekeong ongweekeong

Labels
type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ongweekeong @codecov-io @iamputradanish