Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InboxCommand bugs fixed. Fully functional. #142

Merged
merged 8 commits into from Oct 23, 2018
Merged

InboxCommand bugs fixed. Fully functional. #142

merged 8 commits into from Oct 23, 2018

Conversation

ongweekeong
Copy link

'showunread' can be used multiple times in a single session now.

@ongweekeong ongweekeong added priority.high Must do severity.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u labels Oct 22, 2018
@ongweekeong ongweekeong added this to the v1.3 milestone Oct 22, 2018
@ongweekeong ongweekeong self-assigned this Oct 22, 2018
@codecov-io
Copy link

codecov-io commented Oct 22, 2018

Codecov Report

Merging #142 into master will increase coverage by 0.06%.
The diff coverage is 1.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
+ Coverage     35.48%   35.55%   +0.06%     
  Complexity      233      233              
============================================
  Files            62       63       +1     
  Lines          1657     1654       -3     
  Branches        183      182       -1     
============================================
  Hits            588      588              
+ Misses         1028     1025       -3     
  Partials         41       41
Impacted Files Coverage Δ Complexity Δ
src/seedu/addressbook/Location.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/commands/HelpCommand.java 100% <ø> (ø) 3 <0> (ø) ⬇️
src/seedu/addressbook/inbox/ReadNotification.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/inbox/Msg.java 9.33% <0%> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/inbox/WriteNotification.java 8.47% <0%> (-3.16%) 1 <0> (ø)
src/seedu/addressbook/inbox/MessageFilePaths.java 0% <0%> (ø) 0 <0> (?)
src/seedu/addressbook/timeanddate/TimeAndDate.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/ui/MainWindow.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/commands/InboxCommand.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/inbox/Inbox.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13fb183...ac9941f. Read the comment docs.

@ongweekeong ongweekeong removed the severity.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u label Oct 23, 2018
Copy link

@iamputradanish iamputradanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature implementation. Do update test cases for the feature.

@iamputradanish iamputradanish merged commit 938067a into CS2113-AY1819S1-F10-3:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants