Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .md files from Collate + Updated DG #153

Merged
merged 12 commits into from Oct 27, 2018
Merged

Added .md files from Collate + Updated DG #153

merged 12 commits into from Oct 27, 2018

Conversation

ongweekeong
Copy link

  1. Updated DG to a more consistent format for the Implementation Section
  2. Updated DG to include the "read " command.
  3. Updated DG to include the segments for Request Backup and Dispatch Backup commands in the Implementation section.
  4. Added .md files for our current collate status. Will update again towards the deadline for v1.3 (especially for test code)

@ongweekeong ongweekeong added type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.high Must do labels Oct 27, 2018
@ongweekeong ongweekeong added this to the v1.3 milestone Oct 27, 2018
@ongweekeong ongweekeong self-assigned this Oct 27, 2018
@codecov-io
Copy link

codecov-io commented Oct 27, 2018

Codecov Report

Merging #153 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
+ Coverage     39.37%   39.45%   +0.08%     
  Complexity      271      271              
============================================
  Files            63       63              
  Lines          1816     1812       -4     
  Branches        191      191              
============================================
  Hits            715      715              
+ Misses         1051     1047       -4     
  Partials         50       50
Impacted Files Coverage Δ Complexity Δ
src/seedu/addressbook/Main.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/commands/InboxCommand.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/seedu/addressbook/password/Password.java 28.37% <100%> (ø) 40 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddc7af...84ccf12. Read the comment docs.

Copy link

@muhdharun muhdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reformatting the DG, will ensure subsequent additions of implementations and other info follow the current format

@muhdharun muhdharun merged commit c2e36f7 into CS2113-AY1819S1-F10-3:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.high Must do type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants