Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed parameters for person class and created a patrol resource class #21

Conversation

muhdharun
Copy link

For person class changed and added:
NRIC class
PostalCode class
Status class
Offense class

For PoliceOfficer:
PatrolResource class
Case class (incomplete - need GPS coordinates)
PatrolID class
ReadOnlyPatrollResource interface
State class

Copy link

@andyrobert3 andyrobert3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good groundwork! Impressive.

Copy link

@andyrobert3 andyrobert3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good groundwork!

@andyrobert3 andyrobert3 changed the base branch from master to develop September 28, 2018 09:30
Copy link

@iamputradanish iamputradanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update/delete test cases in future milestone.

@iamputradanish iamputradanish merged commit 0c00d84 into CS2113-AY1819S1-F10-3:develop Oct 1, 2018
@iamputradanish iamputradanish added this to the v1.1 milestone Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants