Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added one-password feature #23

Merged
merged 4 commits into from Sep 27, 2018
Merged

Added one-password feature #23

merged 4 commits into from Sep 27, 2018

Conversation

iamputradanish
Copy link

Password is 12345678

@iamputradanish iamputradanish added type.epic A big feature which can be broken down into smaller stories e.g. search priority.high Must do labels Sep 26, 2018
@iamputradanish iamputradanish added this to the v1.2 milestone Sep 26, 2018
@iamputradanish iamputradanish self-assigned this Sep 26, 2018
andyrobert3
andyrobert3 approved these changes Sep 26, 2018
View reviewed changes
Copy link

@andyrobert3 andyrobert3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and works. I like it.

ShreyasKp
ShreyasKp approved these changes Sep 27, 2018
View reviewed changes
Copy link

@ShreyasKp ShreyasKp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation.

@ShreyasKp
Copy link

The feature seems to be implemented correctly. Good job!

@ShreyasKp ShreyasKp merged commit 940d31e into CS2113-AY1819S1-F10-3:master Sep 27, 2018
@iamputradanish iamputradanish modified the milestones: v1.2, v1.1 Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyrobert3 andyrobert3 andyrobert3 approved these changes

@ShreyasKp ShreyasKp ShreyasKp approved these changes

@muhdharun muhdharun Awaiting requested review from muhdharun

@ongweekeong ongweekeong Awaiting requested review from ongweekeong

Assignees

@iamputradanish iamputradanish

Labels
priority.high Must do type.epic A big feature which can be broken down into smaller stories e.g. search
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamputradanish @ShreyasKp @andyrobert3