Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Notification Class - Tested and working #48

Merged
merged 6 commits into from Oct 5, 2018
Merged

Read Notification Class - Tested and working #48

merged 6 commits into from Oct 5, 2018

Conversation

ongweekeong
Copy link

Now can display number of unread messages. Will implement the actual printing of messages soon

@ongweekeong ongweekeong added status.ongoing The issue is currently being worked on. note: remove this label before closing an issue. priority.high Must do labels Oct 5, 2018
@ongweekeong ongweekeong added this to the v1.2 milestone Oct 5, 2018
@ongweekeong ongweekeong self-assigned this Oct 5, 2018
@iamputradanish iamputradanish modified the milestones: v1.2, v1.3 Oct 5, 2018
Copy link

@iamputradanish iamputradanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Wee Keong, good implementation, but still can improve on the names. Do consider another name to nw, msg and msgType. Refactor your feature in future versions.

@iamputradanish iamputradanish merged commit 72cb5af into CS2113-AY1819S1-F10-3:master Oct 5, 2018
@iamputradanish iamputradanish removed the status.ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants