Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement update password feature #98

Merged
merged 11 commits into from Oct 11, 2018

Conversation

iamputradanish
Copy link

@iamputradanish iamputradanish commented Oct 11, 2018

update password only works for HQP.
command: "update password"
Will refactor in future versions

Currently,
HQP password: mama123
PO password: johnny456

@iamputradanish iamputradanish added type.epic A big feature which can be broken down into smaller stories e.g. search priority.high Must do labels Oct 11, 2018
@iamputradanish iamputradanish added this to the v1.3 milestone Oct 11, 2018
@iamputradanish iamputradanish self-assigned this Oct 11, 2018
Copy link

@ShreyasKp ShreyasKp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation of password feature. However, do refactor and try to follow OOPs concepts.

@ShreyasKp ShreyasKp merged commit 572a41d into CS2113-AY1819S1-F10-3:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.high Must do type.epic A big feature which can be broken down into smaller stories e.g. search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants