Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin management #12

Merged
merged 49 commits into from Sep 30, 2018
Merged

Admin management #12

merged 49 commits into from Sep 30, 2018

Conversation

Psyf
Copy link

@Psyf Psyf commented Sep 29, 2018

Working:

  • Login, logout, addition and removal of admins
  • most corner cases I can think of accounted for
  • You can see //TODO: tags for incomplete things
  • most tests incomplete/not implemented yet
  • no UI changes except CommandLine prompts
  • fixed some merge issues and bugs after JJ's PR

Issues:

  • Works only in memory or in-file in standalone mode. Major rework on events and StorageManager required to work. Currently it is one AddressBook in memory and THREE AddressBooks in file
  • Passwords currently out in the open. Need to implement popup boxes to mask passwords.

@Psyf
Add login Command
c01b5f1
@Psyf
Add stub test for LoginCommand
a8a7319
@Psyf
LoginCommand takes args
cf987d4
@Psyf
move to proper classes in LoginCommand
824857b
@Psyf
Add equality and hashCode to new models
80f0e5e
@Psyf
Add equality to LoginCommand
c4c4d6f
@Psyf
Rename PasswordHash to Password; Add to LoginCommandTest
1e6d8ac
@Psyf
Modify tests, add more test stub for TODO
a2cb936
@Psyf
Add LogoutCommand stubs
1b20e22
@Psyf
Add UniqueAdminList and relevant Exceptions
c331ade
@Psyf
Add test stubs
e3b745a
@Psyf
Add remove method in UniqueAdminList
866c0ff
@Psyf
Edit AddressBook.java to include Admin#methods
b8fce7b
@Psyf
Add model#methods and edit LoginCommand
a6c42f4
@Psyf
Make changes to LogoutCommand#execute
1cebf39
@Psyf
Add initial admin to AB
5eefadc
@Psyf
Fix LoginCommandParser bug
20d617a
@Psyf
Try fix Travis errors
de9f239
@Psyf
Style fix
702f768
@Psyf
Style fix...again
fd7cbef
@Psyf
Style fix...again
d8b278a
@Psyf
Style check...again
4bac37f
@Psyf
Merge branch 'admin_access' into refact-classes
512130a
@Psyf
Merge branch 'refact-classes'
1827efa
@Psyf
Merge remote-tracking branch 'upstream/master'
219ad6b
@Psyf
Added addAdmin Command; working in memory
d5aefd3
@Psyf
Update docs
0781bdb
@Psyf
Some work towards removeAdmin
9175196
@Psyf
removeAdmin working as expected
82c58ce
@Psyf
addAdmin does not allow duplicate usernames
4187bcd
@Psyf Psyf requested a review from teojunjie September 29, 2018 06:32
@Psyf Psyf added type.enhancement New feature or request type.docs Documentation work labels Sep 30, 2018
@Psyf Psyf added this to the v1.1 milestone Sep 30, 2018
@trufflepirate trufflepirate merged commit 9affb07 into CS2113-AY1819S1-T09-1:master Sep 30, 2018
@Psyf Psyf deleted the admin-mgmt branch October 1, 2018 08:53
@Psyf Psyf restored the admin-mgmt branch October 1, 2018 08:55
Psyf pushed a commit that referenced this pull request Oct 31, 2018
@trufflepirate
Merge pull request #12 from CS2113-AY1819S1-T09-1/master
3a0be46 
Setting upsteam
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trufflepirate trufflepirate trufflepirate approved these changes

@teojunjie teojunjie Awaiting requested review from teojunjie

Assignees

@teojunjie teojunjie

@Ftywan Ftywan

@trufflepirate trufflepirate

Labels
type.docs Documentation work type.enhancement New feature or request
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Psyf @trufflepirate @teojunjie @Ftywan