Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.4 UG DG work #153

Merged
merged 100 commits into from Nov 11, 2018
Merged

V1.4 UG DG work #153

merged 100 commits into from Nov 11, 2018

Conversation

teojunjie
Copy link

@teojunjie teojunjie commented Nov 5, 2018 •
edited by Psyf

Mainly the features i implemented for version 1.4 plus some touching up
Saif: and I'm piggybacking off his work!

@teojunjie teojunjie self-assigned this Nov 5, 2018
@teojunjie teojunjie added the type.task Something that needs to be done, but not a story, bug, or an epic label Nov 5, 2018
@teojunjie teojunjie added this to the v1.4.2 milestone Nov 5, 2018
@coveralls
Copy link

coveralls commented Nov 5, 2018 •
edited

Pull Request Test Coverage Report for Build 465

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 58.448%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/ui/MainWindow.java 4 50.0%
Totals Coverage Status
Change from base Build 446: 0.08%
Covered Lines: 2169
Relevant Lines: 3711
💛 - Coveralls

@Psyf Psyf self-assigned this Nov 6, 2018
@Psyf Psyf added type.docs Documentation work priority.high labels Nov 6, 2018
@Psyf Psyf changed the title JJ changes to V1.4 user and developer guide V1.4 UG DG work Nov 6, 2018
@Psyf Psyf modified the milestones: v1.4.2, v1.4.3 Nov 7, 2018
trufflepirate
trufflepirate approved these changes Nov 11, 2018
View reviewed changes
Copy link

@trufflepirate trufflepirate left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the UGDG changes via externally via deployed HTML. @CS2113-AY1819S1-T09-1/developers Please Make sure are happy with your Individual PPP's .

@teojunjie
Copy link
Author

teojunjie commented Nov 11, 2018 •
edited by trufflepirate

I am bun

@trufflepirate
Copy link

Additional Changes reviewed. Merging.

@trufflepirate trufflepirate merged commit 6675b28 into CS2113-AY1819S1-T09-1:master Nov 11, 2018
@Psyf
Copy link

Psyf commented Nov 11, 2018

Go.

This was referenced Nov 11, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trufflepirate trufflepirate trufflepirate approved these changes

Assignees

@Psyf Psyf

@teojunjie teojunjie

Labels
priority.high type.docs Documentation work type.task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@teojunjie @coveralls @trufflepirate @Psyf @Ftywan