Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY2MERGE] Unit Tests #43

Merged
merged 18 commits into from Oct 15, 2018
Merged

[READY2MERGE] Unit Tests #43

merged 18 commits into from Oct 15, 2018

Conversation

Psyf
Copy link

@Psyf Psyf commented Oct 14, 2018 •
edited

  • Unit tests added for AdminCommands
  • RegressionBugs on UpdatePassword Killed
  • Defensive coding increased on commands and classes (mostly requireNonNull)
  • Documentation for Model and Storage Diagrams Updated
  • Password Validation implemented

@Psyf Psyf added the type.testing Testing related work label Oct 14, 2018
@Psyf Psyf added this to the v1.2 milestone Oct 14, 2018
@Psyf Psyf self-assigned this Oct 14, 2018
@Psyf Psyf changed the title Unit Tests for Unit Tests for Admin Commands [NOT READY FOR MERGE] Oct 14, 2018
@Psyf Psyf changed the title Unit Tests for Admin Commands [NOT READY FOR MERGE] Unit Tests Oct 14, 2018
@Psyf Psyf mentioned this pull request Oct 14, 2018
Closed
@Psyf
Copy link
Author

Psyf commented Oct 14, 2018

Weird. The UpdatePasswordCommandTest is working perfectly fine on my dev

@Psyf Psyf added type.enhancement New feature or request type.docs Documentation work labels Oct 15, 2018
@Psyf Psyf mentioned this pull request Oct 15, 2018
Closed
@Psyf Psyf mentioned this pull request Oct 15, 2018
Closed
@Psyf Psyf changed the title Unit Tests [READY2MERGE] Unit Tests Oct 15, 2018
trufflepirate
trufflepirate reviewed Oct 15, 2018
View reviewed changes
Copy link

@trufflepirate trufflepirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the Tests! And the class diagrams as well!

@trufflepirate trufflepirate merged commit 6422de8 into CS2113-AY1819S1-T09-1:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trufflepirate trufflepirate trufflepirate left review comments

Assignees

@Psyf Psyf

Labels
priority.high type.docs Documentation work type.enhancement New feature or request type.testing Testing related work
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Psyf @trufflepirate