Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1.2]Added new Attendee field #58

Merged
merged 14 commits into from Oct 23, 2018
Merged

Conversation

cqinkai
Copy link

@cqinkai cqinkai commented Oct 18, 2018

No description provided.

cqinkai and others added 11 commits October 18, 2018 01:59
…CS2113-AY1819S1-T12-1/main into WIP-New-Attendance-field

# Conflicts:
#	src/main/java/seedu/address/model/event/Event.java
#	src/main/java/seedu/address/ui/EventPageFormatter.java
#	src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/ParserUtilTest.java
#	src/test/java/seedu/address/model/person/EventTest.java
#	src/test/java/seedu/address/model/person/UniqueEventListTest.java
#	src/test/java/seedu/address/testutil/EventBuilder.java
#	src/test/java/systemtests/AddCommandSystemTest.java
#	src/test/java/systemtests/EditCommandSystemTest.java
…into WIP-New-Attendance-field

# Conflicts:
#	src/main/java/seedu/address/logic/commands/AddCommand.java
#	src/main/java/seedu/address/logic/commands/EditCommand.java
#	src/main/java/seedu/address/logic/parser/AddCommandParser.java
#	src/main/java/seedu/address/logic/parser/CliSyntax.java
#	src/main/java/seedu/address/logic/parser/EditCommandParser.java
#	src/main/java/seedu/address/model/event/Event.java
#	src/main/java/seedu/address/model/util/SampleDataUtil.java
#	src/main/java/seedu/address/storage/XmlAdaptedEvent.java
#	src/main/java/seedu/address/ui/BrowserPanel.java
#	src/main/resources/view/EventSearchPage.html
#	src/test/data/XmlEventManagerStorageTest/invalidAndValidEventEventManager.xml
#	src/test/data/XmlEventManagerStorageTest/invalidEventEventManager.xml
#	src/test/data/XmlSerializableEManagerTest/duplicateEventEventManager.xml
#	src/test/data/XmlSerializableEManagerTest/invalidEventEventManager.xml
#	src/test/data/XmlSerializableEManagerTest/typicalEventsEventManager.xml
#	src/test/data/XmlUtilTest/invalidEventField.xml
#	src/test/data/XmlUtilTest/missingEventField.xml
#	src/test/data/XmlUtilTest/validEvent.xml
#	src/test/data/XmlUtilTest/validEventManager.xml
#	src/test/java/seedu/address/commons/util/XmlUtilTest.java
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
#	src/test/java/seedu/address/logic/commands/EditEventDescriptorTest.java
#	src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/EditCommandParserTest.java
#	src/test/java/seedu/address/model/EventManagerTest.java
#	src/test/java/seedu/address/model/event/AddressTest.java
#	src/test/java/seedu/address/model/event/EventContainsKeywordsPredicateTest.java
#	src/test/java/seedu/address/model/event/EventTest.java
#	src/test/java/seedu/address/model/event/NameContainsKeywordsPredicateTest.java
#	src/test/java/seedu/address/model/event/UniqueEventListTest.java
#	src/test/java/seedu/address/model/person/NameContainsKeywordsPredicateTest.java
#	src/test/java/seedu/address/storage/XmlAdaptedEventTest.java
#	src/test/java/seedu/address/testutil/EditPersonDescriptorBuilder.java
#	src/test/java/seedu/address/testutil/EventBuilder.java
#	src/test/java/seedu/address/testutil/EventUtil.java
#	src/test/java/seedu/address/testutil/PersonBuilder.java
#	src/test/java/seedu/address/testutil/TypicalPersons.java
#	src/test/java/seedu/address/ui/BrowserPanelTest.java
#	src/test/java/systemtests/AddCommandSystemTest.java
#	src/test/java/systemtests/EditCommandSystemTest.java
#	src/test/java/systemtests/EventManagerSystemTest.java
#	src/test/java/systemtests/FindCommandSystemTest.java
@cqinkai cqinkai added type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.high Must do labels Oct 22, 2018
@cqinkai cqinkai added this to TO DO in Event Manager via automation Oct 22, 2018
@jamesyaputra jamesyaputra self-requested a review October 22, 2018 13:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 611

  • 140 of 169 (82.84%) changed or added relevant lines in 18 files are covered.
  • 85 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-4.2%) to 77.307%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/model/event/Event.java 14 15 93.33%
src/main/java/seedu/address/model/event/Venue.java 9 10 90.0%
src/main/java/seedu/address/storage/XmlAdaptedAttendee.java 13 15 86.67%
src/main/java/seedu/address/model/user/User.java 1 5 20.0%
src/main/java/seedu/address/ui/EventPageFormatter.java 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/storage/JsonUserStorage.java 2 69.23%
src/main/java/seedu/address/model/user/User.java 3 46.15%
src/main/java/seedu/address/model/user/Username.java 3 60.0%
src/main/java/seedu/address/model/user/Password.java 3 60.0%
src/main/java/seedu/address/logic/commands/LoginCommand.java 9 0.0%
src/main/java/seedu/address/logic/commands/SignupCommand.java 9 0.0%
src/main/java/seedu/address/logic/parser/ParserUtil.java 10 75.68%
src/main/java/seedu/address/logic/parser/LoginCommandParser.java 11 0.0%
src/main/java/seedu/address/logic/parser/SignupCommandParser.java 11 0.0%
src/main/java/seedu/address/storage/Comments.java 24 0.0%
Totals Coverage Status
Change from base Build 603: -4.2%
Covered Lines: 1734
Relevant Lines: 2243

💛 - Coveralls

@jamesyaputra jamesyaputra merged commit 17dbcd1 into master Oct 23, 2018
Event Manager automation moved this from TO DO to DONE Oct 23, 2018
jamesyaputra added a commit that referenced this pull request Oct 23, 2018
…endance-field"

This reverts commit 17dbcd1, reversing
changes made to b2648b1.
jamesyaputra added a commit that referenced this pull request Oct 23, 2018
…-New-Attendance-field""

This reverts commit 54a61ba.
@cqinkai cqinkai changed the title [V1.2][Re-post] Morphed Address field to Venue [V1.2]Added new Attendee field Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.high Must do type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
Event Manager
  
DONE
Development

Successfully merging this pull request may close these issues.

None yet

3 participants