Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request to merge][v1.3] Writing Test Cases #59

Merged
merged 3 commits into from Oct 18, 2018
Merged

[Request to merge][v1.3] Writing Test Cases #59

merged 3 commits into from Oct 18, 2018

Conversation

Geraldcdx
Copy link

No description provided.

@Geraldcdx Geraldcdx added this to TO DO in Event Manager via automation Oct 18, 2018
@Geraldcdx Geraldcdx added type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.high Must do labels Oct 18, 2018
@Geraldcdx Geraldcdx added this to the v1.3 milestone Oct 18, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 520

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 80.91%
Totals Coverage Status
Change from base Build 513: 0.2%
Covered Lines: 1619
Relevant Lines: 2001
💛 - Coveralls

@jamesyaputra jamesyaputra moved this from TO DO to WIP in Event Manager Oct 18, 2018
@Geraldcdx Geraldcdx changed the title [WIP][v1.3] Writing Test Cases [Completed][v1.3] Writing Test Cases Oct 18, 2018
@Geraldcdx
Copy link
Author

@jamesyaputra @chiaxr @cqinkai @Tertium3 Can help me review and merge this tqtq

@Geraldcdx Geraldcdx changed the title [Completed][v1.3] Writing Test Cases [Request to merge][v1.3] Writing Test Cases Oct 18, 2018
jamesyaputra
jamesyaputra approved these changes Oct 18, 2018
View reviewed changes
Copy link

@jamesyaputra jamesyaputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the tests!

@jamesyaputra jamesyaputra merged commit 9488b66 into CS2113-AY1819S1-T12-1:master Oct 18, 2018
Event Manager automation moved this from WIP to DONE Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesyaputra jamesyaputra jamesyaputra approved these changes

@chiaxr chiaxr Awaiting requested review from chiaxr

@cqinkai cqinkai Awaiting requested review from cqinkai

@PhiLong-Ho PhiLong-Ho Awaiting requested review from PhiLong-Ho

Assignees
No one assigned
Labels
priority.high Must do type.task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
Event Manager
  
DONE
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Geraldcdx @coveralls @jamesyaputra