Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding changes made #79

Merged
merged 13 commits into from Oct 23, 2018
Merged

Re-adding changes made #79

merged 13 commits into from Oct 23, 2018

Conversation

jamesyaputra
Copy link

No description provided.

@jamesyaputra jamesyaputra added this to the v1.3 milestone Oct 23, 2018
@jamesyaputra jamesyaputra self-assigned this Oct 23, 2018
@jamesyaputra jamesyaputra added this to TO DO in Event Manager via automation Oct 23, 2018
@coveralls
Copy link

coveralls commented Oct 23, 2018

Pull Request Test Coverage Report for Build 646

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 47 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+2.3%) to 79.621%

Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/logic/comments/Comments.java 1 96.43%
src/main/java/seedu/address/logic/commands/DeleteCommentCommand.java 3 0.0%
src/main/java/seedu/address/logic/commands/AddCommentCommand.java 20 0.0%
src/main/java/seedu/address/logic/commands/ReplyCommentCommand.java 23 0.0%
Totals Coverage Status
Change from base Build 625: 2.3%
Covered Lines: 1805
Relevant Lines: 2267

💛 - Coveralls

Event Manager automation moved this from TO DO to WIP Oct 23, 2018
Copy link

@PhiLong-Ho PhiLong-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test method in PasswordTest line 24 should be rename isValidPassword()
Can password only contain alphanumerical string??? since i see special characters exclude here
Thank for your hard work

@jamesyaputra
Copy link
Author

@Tertium3 Thanks for pointing out the mistake! And special characters are NOT excluded. You can see in one of the test cases that I included special characters.

@PhiLong-Ho
Copy link

Let me merge this for you

@PhiLong-Ho PhiLong-Ho merged commit 80dfa2b into master Oct 23, 2018
Event Manager automation moved this from WIP to DONE Oct 23, 2018
@jamesyaputra jamesyaputra deleted the readd-tests branch October 26, 2018 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Event Manager
  
DONE
Development

Successfully merging this pull request may close these issues.

None yet

3 participants