Skip to content

Commit

Permalink
Merge 1d3cac9 into ba59f37
Browse files Browse the repository at this point in the history
  • Loading branch information
ChenSongJian committed Oct 19, 2018
2 parents ba59f37 + 1d3cac9 commit e429f54
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1109,7 +1109,7 @@ Use case ends.
+
Use case ends.

//@@ChenSongJian
//@@author ChenSongJian
[discrete]
=== Use case: Add Expense(UC11)

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/seedu/address/logic/LogicManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public ObservableList<Person> getFilteredPersonList() {
return model.getFilteredPersonList();
}
/*
//@@ChenSongJian
//@@author ChenSongJian
@Override
public ObservableList<Expense> getFilteredExpenseList() {
return model.getFilteredExpenseList();
Expand Down
12 changes: 9 additions & 3 deletions src/main/java/seedu/address/ui/CommandBox.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import java.util.logging.Logger;
import java.util.stream.Collectors;

import org.controlsfx.control.textfield.AutoCompletionBinding;
import org.controlsfx.control.textfield.TextFields;

import javafx.collections.ObservableList;
Expand All @@ -30,6 +31,7 @@ public class CommandBox extends UiPart<Region> {
private final Logger logger = LogsCenter.getLogger(CommandBox.class);
private final Logic logic;
private ListElementPointer historySnapshot;
private AutoCompletionBinding autoCompletionBinding;

private ArrayList<String> commandList;

Expand All @@ -42,8 +44,8 @@ public CommandBox(Logic logic) {
this.commandList = logic.getCommandList();
// calls #setStyleToDefault() whenever there is a change to the text of the command box.
commandTextField.textProperty().addListener((unused1, unused2, unused3) -> setStyleToDefault());
//@@ChenSongJian
TextFields.bindAutoCompletion(commandTextField, commandList -> {
//@@author ChenSongJian
autoCompletionBinding = TextFields.bindAutoCompletion(commandTextField, commandList -> {
return commandList.getUserText().isEmpty() ? null : this.commandList.stream().filter(command -> {
return command.toLowerCase().startsWith(commandList.getUserText().toLowerCase());
}).collect(Collectors.toList());
Expand Down Expand Up @@ -161,5 +163,9 @@ private void setStyleToIndicateCommandFailure() {

styleClass.add(ERROR_STYLE_CLASS);
}

//@@author ChenSongJian
public void offAutoComplete() {
this.autoCompletionBinding.dispose();
}
//@@
}
2 changes: 1 addition & 1 deletion src/test/java/guitests/guihandles/CommandBoxHandle.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void run(String command) {
click();
guiRobot.interact(() -> getRootNode().setText(command));
guiRobot.pauseForHuman();

guiRobot.type(KeyCode.ESCAPE);
guiRobot.type(KeyCode.ENTER);
}

Expand Down
1 change: 1 addition & 0 deletions src/test/java/seedu/address/ui/CommandBoxTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public void setUp() {
Logic logic = new LogicManager(model);

CommandBox commandBox = new CommandBox(logic);
commandBox.offAutoComplete();
commandBoxHandle = new CommandBoxHandle(getChildNode(commandBox.getRoot(),
CommandBoxHandle.COMMAND_INPUT_FIELD_ID));
uiPartRule.setUiPart(commandBox);
Expand Down

0 comments on commit e429f54

Please sign in to comment.