Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1.2] added predicate classes for address and phone to work on find conta… #52

Closed
wants to merge 2 commits into from
Closed

[V1.2] added predicate classes for address and phone to work on find conta… #52

wants to merge 2 commits into from

Conversation

T0roloco
Copy link

…ct by address and phone

@T0roloco T0roloco changed the title added predicate functions for address and phone to work on find conta… [V1.2] added predicate classes for address and phone to work on find conta… Oct 16, 2018
QzSG
QzSG requested changes Oct 16, 2018
View reviewed changes
Copy link

@QzSG QzSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing typo in the file name?

@QzSG
Copy link

QzSG commented Oct 16, 2018

#53

@T0roloco T0roloco closed this Oct 16, 2018
@T0roloco T0roloco deleted the searchbytag branch October 16, 2018 16:33
@T0roloco T0roloco mentioned this pull request Oct 16, 2018
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 80

  • 0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 77.778%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/model/person/AddressConatinsKeywordsPredicate.java 0 7 0.0%
src/main/java/seedu/address/model/person/PhoneContainsKeywordsPredicate.java 0 7 0.0%
Totals Coverage Status
Change from base Build 78: -0.6%
Covered Lines: 1498
Relevant Lines: 1926
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 79

  • 0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 77.778%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/model/person/AddressConatinsKeywordsPredicate.java 0 7 0.0%
src/main/java/seedu/address/model/person/PhoneContainsKeywordsPredicate.java 0 7 0.0%
Totals Coverage Status
Change from base Build 78: -0.6%
Covered Lines: 1498
Relevant Lines: 1926
💛 - Coveralls

@nus-pe-script nus-pe-script mentioned this pull request Oct 18, 2018
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QzSG QzSG QzSG requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@T0roloco @QzSG @coveralls