[v1.2] Backup Feature #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add backup file path to user preferences model. Modified equals to compare backup location Modified string builder to include backup path
Modify ExtraValues json test file Add `addressBookBackupFilePath` to typical user prefs json test file
[Model] UserPrefs is required to be in model manager as commands run can affect user preferences which should be part of model. Refer to original AB4 architecture diagram Added getUserPref method to Model interface Fix UserPref model returning wrong path in getAddressBookBackupFilePath [Tests] Fix Stubbed ModelManager in AddCommandTest
Make AddressBookStorage and XmlAddressBookStorage have the required backup methods
As long as AddressBook data are equal, userprefs can be different which is okay
Backup Command currently calls model.backupAddressBook, perhaps we should raise a backup request event from command direct and get handled by storage manager directly as we do not need to modify the model
More tests Bug Fixes
Resolve conflicts
Impossible to make exception to be thrown on linux even with mocking for invalid paths
Create generic online storage module Implement working backup to github gist Modify backup command to accept github backup
Runs worker thread when uploading to github gists Ui popups with error if invalid access token provided and detected inside worker task. If success, UI updated with success message and provides url to uploaded Gist
Local and Github Restore added Bug fixes TODO: Save gist id on backup into userprefs Added UI
QzSG
added
enhancement
GSzQ
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant #38