Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DeleteEventCommand #76

Merged
merged 14 commits into from
Oct 24, 2018
Merged

Conversation

ian-tjahjono
Copy link

Will work on tests soon

@coveralls
Copy link

Pull Request Test Coverage Report for Build 127

  • 0 of 72 (0.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 60.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/LogicManager.java 0 1 0.0%
src/main/java/seedu/address/logic/parser/AddressBookParser.java 0 1 0.0%
src/main/java/seedu/address/model/ModelManager.java 0 2 0.0%
src/main/java/seedu/address/commons/events/ui/EventPanelSelectionChangedEvent.java 0 5 0.0%
src/main/java/seedu/address/logic/parser/DeleteEventCommandParser.java 0 6 0.0%
src/main/java/seedu/address/logic/commands/DeleteEventCommand.java 0 13 0.0%
src/main/java/seedu/address/ui/EventCard.java 0 13 0.0%
src/main/java/seedu/address/ui/EventListPanel.java 0 31 0.0%
Totals Coverage Status
Change from base Build 124: -1.6%
Covered Lines: 1681
Relevant Lines: 2777

💛 - Coveralls

Copy link

@QzSG QzSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

requireNonNull(model);
List<Event> lastShownList = model.getFilteredEventList();

if (targetIndex.getZeroBased() >= lastShownList.size()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good usage of guard clause

@QzSG
Copy link

QzSG commented Oct 24, 2018

Relevant #65

@QzSG QzSG merged commit ae7d85e into CS2113-AY1819S1-T13-1:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants