Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full implementation of SalesHistory #106

Merged
merged 7 commits into from Oct 31, 2018

Conversation

ParasK26
Copy link

In this, I work to implement file storage for the saleshistory, and some additional commands.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 304

  • 0 of 418 (0.0%) changed or added relevant lines in 26 files are covered.
  • 22 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.3%) to 5.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/commands/AddReminderCommand.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/ViewAllRemindersCommand.java 0 1 0.0%
src/main/java/seedu/address/logic/parser/ParserUtil.java 0 1 0.0%
src/main/java/seedu/address/model/product/Product.java 0 1 0.0%
src/main/java/seedu/address/model/util/SampleDataUtil.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/ThreadDueRemindersCommand.java 0 2 0.0%
src/main/java/seedu/address/logic/commands/ViewDueRemindersCommand.java 0 2 0.0%
src/main/java/seedu/address/model/UserPrefs.java 0 2 0.0%
src/main/java/seedu/address/model/timeidentifiedclass/exceptions/ProductQuantityMismatchException.java 0 2 0.0%
src/main/java/seedu/address/MainApp.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/logic/parser/AddReminderCommandParser.java 1 0.0%
src/main/java/seedu/address/logic/parser/FinishedReminderCommandParser.java 1 0.0%
src/main/java/seedu/address/logic/commands/FinishedReminderCommand.java 1 0.0%
src/main/java/seedu/address/storage/XmlAdaptedTransaction.java 3 0.0%
src/main/java/seedu/address/storage/StorageManager.java 3 0.0%
src/main/java/seedu/address/model/saleshistory/SalesHistory.java 5 0.0%
src/main/java/seedu/address/model/ModelManager.java 8 0.0%
Totals Coverage Status
Change from base Build 303: -0.3%
Covered Lines: 179
Relevant Lines: 3368

💛 - Coveralls

@ParasK26 ParasK26 changed the title Paras's work for v1.3 Full implementation of SalesHistory Oct 31, 2018
@ParasK26 ParasK26 merged commit f85db07 into CS2113-AY1819S1-T13-3:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants