Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add and edit commands involving distributors - distributors with same name or phone (unless it is 00000000) not allowed #180

Merged
merged 5 commits into from Nov 11, 2018

Conversation

dyeosy98
Copy link

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 466

  • 52 of 151 (34.44%) changed or added relevant lines in 21 files are covered.
  • 69 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-1.01%) to 29.238%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/MainApp.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/AddDistributorCommand.java 2 4 50.0%
src/main/java/seedu/address/model/distributor/Distributor.java 16 18 88.89%
src/main/java/seedu/address/model/distributor/DistributorProduct.java 8 10 80.0%
src/main/java/seedu/address/logic/parser/AddDistributorCommandParser.java 0 3 0.0%
src/main/java/seedu/address/logic/parser/AllCommandsParser.java 0 4 0.0%
src/main/java/seedu/address/commons/events/ui/DistributorProductPanelSelectionChangedEvent.java 0 5 0.0%
src/main/java/seedu/address/logic/parser/AddCommandParser.java 0 5 0.0%
src/main/java/seedu/address/model/util/SampleDistributorsUtil.java 3 9 33.33%
src/main/java/seedu/address/logic/parser/ListDistributorProductsCommandParser.java 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/model/ModelManager.java 1 29.58%
src/main/java/seedu/address/logic/parser/AddCommandParser.java 1 0.0%
src/main/java/seedu/address/logic/parser/AddDistributorCommandParser.java 1 0.0%
src/main/java/seedu/address/model/tag/Tag.java 2 80.0%
src/main/java/seedu/address/model/distributor/UniqueDistributorList.java 2 69.77%
src/main/java/seedu/address/storage/XmlFileStorage.java 3 9.09%
src/main/java/seedu/address/model/DistributorBook.java 4 82.14%
src/main/java/seedu/address/storage/XmlAdaptedTag.java 6 0.0%
src/main/java/seedu/address/commons/util/XmlUtil.java 8 35.29%
src/main/java/seedu/address/storage/XmlSerializableDistributorBook.java 9 25.0%
Totals Coverage Status
Change from base Build 460: -1.01%
Covered Lines: 1097
Relevant Lines: 3752

💛 - Coveralls

@dyeosy98 dyeosy98 merged commit f9080af into CS2113-AY1819S1-T13-3:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants