Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated UG and enhanced module delete #238

Merged
merged 4 commits into from Oct 31, 2018
Merged

Updated UG and enhanced module delete #238

merged 4 commits into from Oct 31, 2018

Conversation

harriuscai
Copy link
Collaborator

UG:

  • specifically stated that searching for modules will match whole words to the keywords, so partial search i.e. engin for Engineering is not possible.

Module delete:

  • calls on ClassroomManager#handleModuleDeletedByModuleCode() to delete classes attached to the deleted module

@harriuscai harriuscai added Changes in Documentation This PR contains changes to documentation Changes in Code This PR contains changes to code labels Oct 31, 2018
@harriuscai harriuscai added this to the v1.3 milestone Oct 31, 2018
@harriuscai harriuscai requested a review from a team as a code owner October 31, 2018 17:06
@coveralls
Copy link

coveralls commented Oct 31, 2018 •
edited

Coverage Status

Coverage decreased (-0.01%) to 55.832% when pulling bc19bdd on harriuscai:master into 8d40242 on CS2113-AY1819S1-T16-1:master.

@harriuscai harriuscai merged commit 12b2db2 into CS2113-AY1819S1-T16-1:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristyxxnana tristyxxnana tristyxxnana approved these changes

Assignees
No one assigned
Labels
Changes in Code This PR contains changes to code Changes in Documentation This PR contains changes to documentation
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harriuscai @coveralls @tristyxxnana