forked from nusCS2113-AY1819S1/addressbook-level4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.4 Check Command Update #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pinjuen
commented
Oct 31, 2018
•
edited
edited
- took out check in time and working rate from Person Card
- different colors for check in and out status
- took out NRIC and Password from command
- not allow more than one repeated prefix
- updated user guide and developer guide accordingly.
…into uiUpdate # Conflicts: # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/test/java/seedu/address/testutil/TypicalPersons.java
speezy37
previously requested changes
Nov 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting for UI changes
- removed working rate and check in time on person card - changing colour when checking in/out
…into uiUpdate # Conflicts: # docs/UserGuide.adoc # src/main/java/seedu/address/model/util/SampleDataUtil.java
# Conflicts: # docs/UserGuide.adoc
- not allow more than one prefix - updated user guide
- fix checkstyle
pinjuen
added
enhancement
New feature or request
update.documentation
Update of documentation
v1.4
labels
Nov 5, 2018
jinyao-lee
approved these changes
Nov 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI looks good to me.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.