Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test cases #106

Merged
merged 9 commits into from Nov 2, 2018
Merged

Added test cases #106

merged 9 commits into from Nov 2, 2018

Conversation

speezy37
Copy link
Collaborator

@speezy37 speezy37 commented Nov 1, 2018 •
edited

Added test cases for most parameters of Person & Schedule

Change homepage link to www.bing.com (to be removed in #108)

Bug fixes

  • fixed a bug where schedule time start & time end is the same

@speezy37 speezy37 self-assigned this Nov 1, 2018
@speezy37 speezy37 added the update.testcases Update of test cases label Nov 1, 2018
@speezy37 speezy37 added the bug Something isn't working label Nov 2, 2018
@Woonhian Woonhian added this to In progress in Main Project via automation Nov 2, 2018
jinyao-lee
jinyao-lee approved these changes Nov 2, 2018
View reviewed changes
Copy link
Collaborator

@jinyao-lee jinyao-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved

Woonhian
Woonhian approved these changes Nov 2, 2018
View reviewed changes
Copy link
Collaborator

@Woonhian Woonhian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved.

@Woonhian Woonhian merged commit aeeb17b into CS2113-AY1819S1-T16-3:master Nov 2, 2018
Main Project automation moved this from In progress to Done Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Woonhian Woonhian Woonhian approved these changes

@jinyao-lee jinyao-lee jinyao-lee approved these changes

Assignees

@speezy37 speezy37

Labels
bug Something isn't working update.testcases Update of test cases
Projects
No open projects
Main Project
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@speezy37 @Woonhian @jinyao-lee