Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.4: Dev Guide Documentation #148

Merged
merged 16 commits into from Nov 11, 2018
Merged

V1.4: Dev Guide Documentation #148

merged 16 commits into from Nov 11, 2018

Conversation

Hafizuddin-github
Copy link
Collaborator

@Hafizuddin-github Hafizuddin-github commented Nov 10, 2018 •
edited

  • Updated user stories
  • Updated use cases
  • Updated UI component diagram
  • Updated Storage component diagram
  • Updated Model Component diagram
  • Updated Dev guide for leave related commands
  • Updated User guide for leave command
  • Updated PPP
  • Updated UI.png

@Hafizuddin-github Hafizuddin-github self-assigned this Nov 10, 2018
@Hafizuddin-github Hafizuddin-github added v1.4 update.documentation Update of documentation labels Nov 10, 2018
@Hafizuddin-github Hafizuddin-github added this to In progress in Main Project via automation Nov 10, 2018
@Hafizuddin-github Hafizuddin-github added this to the v1.4 milestone Nov 10, 2018
@Woonhian Woonhian self-requested a review November 11, 2018 07:15
@Hafizuddin-github Hafizuddin-github added the update.code Update of code label Nov 11, 2018
Woonhian
Woonhian reviewed Nov 11, 2018
View reviewed changes
Copy link
Collaborator

@Woonhian Woonhian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on updating, maybe can make a few changes before I merge.

docs/DeveloperGuide.adoc Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
Woonhian
Woonhian reviewed Nov 11, 2018
View reviewed changes
Copy link
Collaborator

@Woonhian Woonhian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the feedback.

docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
Woonhian
Woonhian approved these changes Nov 11, 2018
View reviewed changes
Copy link
Collaborator

@Woonhian Woonhian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved.

@Woonhian Woonhian merged commit a3d7657 into CS2113-AY1819S1-T16-3:master Nov 11, 2018
Main Project automation moved this from In progress to Done Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Woonhian Woonhian Woonhian approved these changes

Assignees

@Hafizuddin-github Hafizuddin-github

Labels
update.code Update of code update.documentation Update of documentation v1.4
Projects
No open projects
Main Project
  
Done
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hafizuddin-github @Woonhian