Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/UserGuide.adoc #89

Merged

Conversation

jinyao-lee
Copy link
Collaborator

@jinyao-lee jinyao-lee commented Oct 29, 2018

Removal of commands

  • Removed UndoCommand and RedoCommand, as the application is not intended to implement UndoCommand and RedoCommand.
  • Revoed ClearCommand, as the command has been replaced by ResetCommand.

Miscellaneous

  • Updated UserGuide.adoc

@Woonhian Woonhian added update.documentation Update of documentation update.code Update of code labels Oct 30, 2018
@Woonhian Woonhian added this to the v1.3 milestone Oct 30, 2018
@Woonhian Woonhian added this to In progress in Main Project via automation Oct 30, 2018
Copy link
Collaborator

@Woonhian Woonhian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just need to change a bit of stuffs will do

docs/UserGuide.adoc Show resolved Hide resolved
docs/UserGuide.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@Woonhian Woonhian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update, just need to change a few stuffs before merging

• *Reset the application*: `reset`
• *Exit application*: `exit`
//• *Restrict access to BankAB*: `restrict`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment can be deleted since we will not be using it.

public void parseCommand_undoCommandWord_returnsUndoCommand() throws Exception {
assertTrue(parser.parseCommand(UndoCommand.COMMAND_WORD) instanceof UndoCommand);
assertTrue(parser.parseCommand("undo 3") instanceof UndoCommand);
}
}*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment can be deleted since we will not be using it.

Copy link
Collaborator

@Woonhian Woonhian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved.

@Woonhian Woonhian merged commit 965cd43 into CS2113-AY1819S1-T16-3:master Oct 31, 2018
Main Project automation moved this from In progress to Done Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update.code Update of code update.documentation Update of documentation
Projects
No open projects
Main Project
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants