Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating schedule comments in code and documentation #115

Merged
merged 10 commits into from Oct 20, 2018
Merged

Updating schedule comments in code and documentation #115

merged 10 commits into from Oct 20, 2018

Conversation

zhihong8888
Copy link
Collaborator

@zhihong8888 zhihong8888 commented Oct 20, 2018 •
edited

  • User guide for schedule updated
  • Comments for all schedule codes amended

@coveralls
Copy link

coveralls commented Oct 20, 2018 •
edited

Pull Request Test Coverage Report for Build 421

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 68.711%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/model/schedule/ScheduleList.java 1 79.17%
Totals Coverage Status
Change from base Build 408: 0.0%
Covered Lines: 2196
Relevant Lines: 3196
💛 - Coveralls

@zhihong8888 zhihong8888 added the update.documentation Documentation Update label Oct 20, 2018
@zhihong8888 zhihong8888 added this to the v1.3 milestone Oct 20, 2018
@zhihong8888 zhihong8888 added v1.3 v1.3 Milestone v1.2 v1.2 Milestone and removed v1.3 v1.3 Milestone labels Oct 20, 2018
@zhihong8888 zhihong8888 removed this from the v1.3 milestone Oct 20, 2018
@zhihong8888 zhihong8888 removed the v1.2 v1.2 Milestone label Oct 20, 2018
@LimYiSheng LimYiSheng self-requested a review October 20, 2018 09:28
LimYiSheng
LimYiSheng approved these changes Oct 20, 2018
View reviewed changes
Copy link
Collaborator

@LimYiSheng LimYiSheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job in updating the comments and user guide, PR approved. Next person to check do merge if all is good.

@XiiaoPanda XiiaoPanda self-requested a review October 20, 2018 09:34
XiiaoPanda
XiiaoPanda approved these changes Oct 20, 2018
View reviewed changes
Copy link
Collaborator

@XiiaoPanda XiiaoPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@XiiaoPanda XiiaoPanda merged commit 82bf538 into CS2113-AY1819S1-T16-4:master Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiiaoPanda XiiaoPanda XiiaoPanda approved these changes

@LimYiSheng LimYiSheng LimYiSheng approved these changes

Assignees

@zhihong8888 zhihong8888

Labels
update.documentation Documentation Update
Projects
No open projects
Centralized Human Resource System (CHRS)
  
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhihong8888 @coveralls @XiiaoPanda @LimYiSheng