Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.3.1 Enhancements #120

Merged
merged 14 commits into from Oct 23, 2018
Merged

V1.3.1 Enhancements #120

merged 14 commits into from Oct 23, 2018

Conversation

LimYiSheng
Copy link
Collaborator

@LimYiSheng LimYiSheng commented Oct 22, 2018 •
edited

Mid v1.3.1 Updates:

  • Created EmployeeIdContainsKeywordPredicate [it only accepts one keyword for checking]
  • Created EmployeeIdContainsKeywordPredicate test file
  • Updated TypicalPersons. typicalPersonAddressBook and PersonBuilder to not have any duplicate employeeIds
  • Updated test files accordingly
  • Updated comments within files

@LimYiSheng LimYiSheng changed the title Mid-v1.3 Enhancements Mid-v1.3 Enhancements [Trial] Oct 22, 2018
@LimYiSheng LimYiSheng self-assigned this Oct 22, 2018
@LimYiSheng LimYiSheng closed this Oct 22, 2018
@LimYiSheng LimYiSheng reopened this Oct 22, 2018
@coveralls
Copy link

coveralls commented Oct 22, 2018 •
edited

Pull Request Test Coverage Report for Build 450

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 70.097%
Totals Coverage Status
Change from base Build 427: 0.1%
Covered Lines: 2234
Relevant Lines: 3187
💛 - Coveralls

@LimYiSheng LimYiSheng added this to the v1.3 milestone Oct 23, 2018
@LimYiSheng LimYiSheng added type.enhancement An enhancement to an existing story priority.high Must do update.testcase Test Cases Update labels Oct 23, 2018
ChuaZhenWei
ChuaZhenWei approved these changes Oct 23, 2018
View reviewed changes
Copy link
Collaborator

@ChuaZhenWei ChuaZhenWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good coding practice
Test files return successful results for newly created files

@LimYiSheng LimYiSheng changed the title Mid-v1.3 Enhancements [Trial] Mid-v1.3 Enhancements Oct 23, 2018
@ryanchen2018 ryanchen2018 self-requested a review October 23, 2018 15:13
ryanchen2018
ryanchen2018 approved these changes Oct 23, 2018
View reviewed changes
Copy link
Collaborator

@ryanchen2018 ryanchen2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done for successful test files and PR approved.

@ryanchen2018 ryanchen2018 merged commit d50e2a8 into CS2113-AY1819S1-T16-4:master Oct 23, 2018
@LimYiSheng LimYiSheng changed the title Mid-v1.3 Enhancements V1.3.1 Enhancements Oct 28, 2018
@LimYiSheng LimYiSheng added the v1.3 v1.3 Milestone label Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanchen2018 ryanchen2018 ryanchen2018 approved these changes

@ChuaZhenWei ChuaZhenWei ChuaZhenWei approved these changes

Assignees

@LimYiSheng LimYiSheng

Labels
priority.high Must do type.enhancement An enhancement to an existing story update.testcase Test Cases Update v1.3 v1.3 Milestone
Projects
No open projects
Centralized Human Resource System (CHRS)
  
Awaiting triage
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LimYiSheng @coveralls @ryanchen2018 @ChuaZhenWei