Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recruitment v1.3.5 #155

Merged
merged 4 commits into from Oct 31, 2018
Merged

Recruitment v1.3.5 #155

merged 4 commits into from Oct 31, 2018

Conversation

ryanchen2018
Copy link
Collaborator

@ryanchen2018 ryanchen2018 commented Oct 31, 2018 •
edited

Resolves #53 issue.

  • Add editRecruitmentPost command with its command alias: erp
    to edit recruitment posts if necessary.

  • Update the user guide accordingly.

@ryanchen2018 ryanchen2018 self-assigned this Oct 31, 2018
@ryanchen2018 ryanchen2018 added type.story A user story priority.high Must do v1.3 v1.3 Milestone labels Oct 31, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 746

  • 0 of 117 (0.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.5%) to 56.592%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/AddressBookParser.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/AddRecruitmentPostCommand.java 0 9 0.0%
src/main/java/seedu/address/model/recruitment/Recruitment.java 0 15 0.0%
src/main/java/seedu/address/logic/parser/EditRecruitmentPostCommandParser.java 0 20 0.0%
src/main/java/seedu/address/logic/commands/EditRecruitmentPostCommand.java 0 72 0.0%
Totals Coverage Status
Change from base Build 727: -1.5%
Covered Lines: 2537
Relevant Lines: 4483
💛 - Coveralls

@LimYiSheng LimYiSheng self-requested a review October 31, 2018 16:11
LimYiSheng
LimYiSheng approved these changes Oct 31, 2018
View reviewed changes
Copy link
Collaborator

@LimYiSheng LimYiSheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved, merging

@LimYiSheng LimYiSheng merged commit 5e69683 into CS2113-AY1819S1-T16-4:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LimYiSheng LimYiSheng LimYiSheng approved these changes

Assignees

@ryanchen2018 ryanchen2018

Labels
priority.high Must do type.story A user story v1.3 v1.3 Milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanchen2018 @coveralls @LimYiSheng