Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UserGuide.adoc #172

Merged
merged 4 commits into from Nov 1, 2018
Merged

Update UserGuide.adoc #172

merged 4 commits into from Nov 1, 2018

Conversation

LimYiSheng
Copy link
Collaborator

@LimYiSheng LimYiSheng commented Nov 1, 2018 •
edited

Added limitation to fields under person in UserGuide.adoc

@LimYiSheng LimYiSheng added priority.high Must do update.documentation Documentation Update labels Nov 1, 2018
@LimYiSheng LimYiSheng added this to the v1.4 milestone Nov 1, 2018
@LimYiSheng LimYiSheng self-assigned this Nov 1, 2018
@LimYiSheng LimYiSheng removed this from the v1.4 milestone Nov 1, 2018
@coveralls
Copy link

coveralls commented Nov 1, 2018 •
edited

Pull Request Test Coverage Report for Build 818

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.495%
Totals Coverage Status
Change from base Build 817: 0.0%
Covered Lines: 2565
Relevant Lines: 4622
💛 - Coveralls

XiiaoPanda
XiiaoPanda approved these changes Nov 1, 2018
View reviewed changes
Copy link
Collaborator

@XiiaoPanda XiiaoPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@LimYiSheng LimYiSheng removed the priority.high Must do label Nov 1, 2018
@ChuaZhenWei ChuaZhenWei merged commit e6ab1e2 into CS2113-AY1819S1-T16-4:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiiaoPanda XiiaoPanda XiiaoPanda approved these changes

Assignees

@LimYiSheng LimYiSheng

Labels
update.documentation Documentation Update
Projects
No open projects
Centralized Human Resource System (CHRS)
  
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LimYiSheng @coveralls @XiiaoPanda @ChuaZhenWei